Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utilies to update data objects moved to utils #190

Merged
merged 8 commits into from
Sep 6, 2023
Merged

utilies to update data objects moved to utils #190

merged 8 commits into from
Sep 6, 2023

Conversation

allaffa
Copy link
Collaborator

@allaffa allaffa commented Aug 23, 2023

No description provided.

@allaffa allaffa added bug Something isn't working enhancement New feature or request labels Aug 23, 2023
@allaffa allaffa self-assigned this Aug 23, 2023
jychoi-hpc
jychoi-hpc approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@jychoi-hpc jychoi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

pzhanggit
pzhanggit reviewed Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@pzhanggit pzhanggit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.
Could you do a grep search to make sure if all calls related to update_predicted_values and update_atom_features are updated accordingly? Thanks.

@allaffa
Copy link
Collaborator Author

allaffa commented Aug 25, 2023

The changes look good to me.
Could you do a grep search to make sure if all calls related to update_predicted_values and update_atom_features are updated accordingly? Thanks.

@pzhanggit
Thanks. Indeed, I had forgotten to change it inside abstractrawdataset.py. I noticed that the class inheritance from abstractrawdataset.py was not guarded. Therefore, I created a pytest to check this. Th new pytest is called test_datasetclass_inheritance.py

@jychoi-hpc
Copy link
Member

jychoi-hpc commented Sep 3, 2023 •
edited
Loading

Regarding the citest failure, I ran on my local machine and found test_datasetclass_inheritance.py is causing a problem. It looks like there is a conflict in using ddp inside pytest with mutliple test cases. I will look for some examples in the internet.

@allaffa
Copy link
Collaborator Author

allaffa commented Sep 6, 2023

@jychoi-hpc @pzhanggit
Wait for the CI test to end, and then you can proceed reviewing this PR one more time :-)

@allaffa allaffa merged commit 8998ea2 into ORNL:main Sep 6, 2023
3 checks passed
@allaffa allaffa deleted the move_update_features_utils branch September 6, 2023 19:40
RylieWeaver pushed a commit to RylieWeaver/HydraGNN that referenced this pull request Oct 17, 2024
@allaffa @jychoi-hpc
utilies to update data objects moved to utils (ORNL#190)
df51d10 
* utilies to update data objects moved to utils

* pytest to check class inheritance of dataset from abstractrawdataset

* reformatting

* merge conflicts resolved

* hasattr call fixed

* formatting

* fix for the ci test error

---------

Co-authored-by: Choi <choij@ornl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzhanggit pzhanggit pzhanggit approved these changes

@jychoi-hpc jychoi-hpc Awaiting requested review from jychoi-hpc

Assignees

@allaffa allaffa

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allaffa @jychoi-hpc @pzhanggit